viirya commented on code in PR #7233: URL: https://github.com/apache/arrow-datafusion/pull/7233#discussion_r1287707284
########## benchmarks/queries/q8.sql: ########## @@ -1,9 +1,9 @@ select o_year, - cast(cast(sum(case - when nation = 'BRAZIL' then volume - else 0 - end) as decimal(12,2)) / cast(sum(volume) as decimal(12,2)) as decimal(15,2)) as mkt_share + sum(case + when nation = 'BRAZIL' then volume + else 0 + end) / sum(volume) as mkt_share Review Comment: Looks okay, all tests are passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org