mqy commented on a change in pull request #9025:
URL: https://github.com/apache/arrow/pull/9025#discussion_r550250838
##########
File path: rust/arrow/src/datatypes.rs
##########
@@ -1903,9 +1929,20 @@ mod tests {
#[test]
fn serde_struct_type() {
+ let kv_array = [("k".to_string(), "v".to_string())];
Review comment:
> I can't remember where I encountered it, might be in the `0.14.1` test
files. A quick way of seeing where the object example comes from, is to comment
out that portion of the code, and run the integration tests.
@nevi-me After comment out, datatypes::tests::schema_json failed, but the
test data are not from `testing` module, instead are manually constructed.
Files with "metadata" in the file name can only be found in these directories:
1.0.0-bigendian and 1.0.0-littleendian/. The Object format for Schema metadata
came from https://github.com/apache/arrow/pull/5907 by @grundprinzip
Anyway, I think it's no harm to support parsing `Field` metadata from JSON
`Object(Map)`, just as what Schema did.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
