alamb commented on code in PR #7252:
URL: https://github.com/apache/arrow-datafusion/pull/7252#discussion_r1290226058
##########
datafusion/core/src/datasource/physical_plan/json.rs:
##########
@@ -374,17 +376,19 @@ mod tests {
async fn test_additional_stores(
file_compression_type: FileCompressionType,
store: Arc<dyn ObjectStore>,
- ) {
+ ) -> Result<()> {
let ctx = SessionContext::new();
let url = Url::parse("file://").unwrap();
ctx.runtime_env().register_object_store(&url, store.clone());
let filename = "1.json";
+ let tmp_dir = TempDir::new()?;
Review Comment:
FWIW it is also fine in test code to use `unwrap()` and avoid having to
return `Result`s -- either is acceptable I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
