vmuddassir-msft commented on code in PR #4573:
URL: https://github.com/apache/arrow-rs/pull/4573#discussion_r1290551821
##########
object_store/src/azure/mod.rs:
##########
@@ -889,7 +896,17 @@ impl MicrosoftAzureBuilder {
self.parse_url(&url)?;
}
- let container = self.container_name.ok_or(Error::MissingContainerName
{})?;
+ let use_ok_or = match &self.account_name {
+ Some(account_name) => !account_name.contains("onelake"),
+ None => true,
+ };
+
+ let container = if use_ok_or {
+ self.container_name.ok_or(Error::MissingContainerName {})?
+ } else {
+ self.container_name.unwrap_or_default()
+ };
Review Comment:
I removed this check. The original intention was to skip the container name
check if it was set using the URL scheme
"onelake.dfs.fabric.microsoft.com/<workspaceGUID>". This behavior has now been
addressed in the 'parse_url' function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
