viirya commented on code in PR #7274:
URL: https://github.com/apache/arrow-datafusion/pull/7274#discussion_r1292518950
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -1186,7 +1194,9 @@ impl BuiltinScalarFunction {
| BuiltinScalarFunction::Sqrt
| BuiltinScalarFunction::Tan
| BuiltinScalarFunction::Tanh
- | BuiltinScalarFunction::Cot => {
+ | BuiltinScalarFunction::Cot
+ | BuiltinScalarFunction::Isnan
+ | BuiltinScalarFunction::Iszero => {
Review Comment:
I would consider `Isnan` and `Iszero` not math expressions as listed here.
The reason to give f64 high priority is also not applied too for these two
expressions, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
