kou commented on code in PR #36835:
URL: https://github.com/apache/arrow/pull/36835#discussion_r1293183618
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -5039,6 +5054,154 @@ if(ARROW_S3)
endif()
endif()
+# ----------------------------------------------------------------------
+# Azure SDK for C++
+
+macro(build_azuresdk)
+ message(STATUS "Building Azure C++ SDK from source")
+
+ find_curl()
+ find_package(LibXml2 REQUIRED)
+ add_custom_target(azure_sdk_dependencies)
+
+ if(NOT OpenSSL_FOUND)
+ resolve_dependency(OpenSSL HAVE_ALT REQUIRED_VERSION
+ ${ARROW_OPENSSL_REQUIRED_VERSION})
+ endif()
+
+ set(AZURESDK_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/azuresdk_ep-install")
+ set(AZURESDK_INCLUDE_DIR "${AZURESDK_PREFIX}/include")
+ set(AZURESDK_LIB_DIR "lib")
+
+ set(AZURESDK_COMMON_CMAKE_ARGS
+ ${EP_COMMON_CMAKE_ARGS}
+ "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>"
+ "-DCMAKE_PREFIX_PATH=${AZURESDK_PREFIX}"
+ -DBUILD_SHARED_LIBS=OFF
+ -DCMAKE_INSTALL_LIBDIR=${AZURESDK_LIB_DIR}
+ -DDISABLE_AZURE_CORE_OPENTELEMETRY=ON
+ -DENABLE_TESTING=OFF
+ -DENABLE_UNITY_BUILD=ON
+ -DWARNINGS_AS_ERRORS=OFF)
+
+ STRING(REPLACE "." ";" OPENSSL_VERSION_ELEMENTS_LIST ${OPENSSL_VERSION})
+ list(GET OPENSSL_VERSION_ELEMENTS_LIST 0 OPENSSL_VERSION_MAJOR)
+ if(OPENSSL_VERSION_MAJOR EQUAL 1)
+ list(APPEND
+ AZURESDK_COMMON_CMAKE_ARGS
+
-DVCPKG_OVERLAY_PORTS=${CMAKE_CURRENT_BINARY_DIR}/azuresdk_ep-prefix/src/azuresdk_ep/vcpkg-custom-ports)
+ elseif(OPENSSL_VERSION_MAJOR EQUAL 3)
+ else()
+ message(FATAL_ERROR "Unknown OpenSSL version: ${OPENSSL_VERSION}")
+ endif()
+
+ file(MAKE_DIRECTORY ${AZURESDK_INCLUDE_DIR})
+ set(AZURE_CORE_STATIC_LIBRARY
+
"${AZURESDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}azure-core${CMAKE_STATIC_LIBRARY_SUFFIX}"
+ )
+ set(AZURE_IDENTITY_STATIC_LIBRARY
+
"${AZURESDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}azure-identity${CMAKE_STATIC_LIBRARY_SUFFIX}"
+ )
+ set(AZURE_STORAGE_BLOBS_STATIC_LIBRARY
+
"${AZURESDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}azure-storage-blobs${CMAKE_STATIC_LIBRARY_SUFFIX}"
+ )
+ set(AZURE_STORAGE_COMMON_STATIC_LIBRARY
+
"${AZURESDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}azure-storage-common${CMAKE_STATIC_LIBRARY_SUFFIX}"
+ )
+ set(AZURE_STORAGE_FILES_DATALAKE_STATIC_LIBRARY
+
"${AZURESDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}azure-storage-files-datalake${CMAKE_STATIC_LIBRARY_SUFFIX}"
+ )
+ externalproject_add(azuresdk_ep
+ ${EP_COMMON_OPTIONS}
+ INSTALL_DIR ${AZURESDK_PREFIX}
+ URL ${ARROW_AZURESDK_URL}
+ URL_HASH
"SHA256=${ARROW_AZURE_SDK_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${AZURESDK_COMMON_CMAKE_ARGS}
+ BUILD_BYPRODUCTS ${AZURE_CORE_STATIC_LIBRARY}
+ ${AZURE_IDENTITY_STATIC_LIBRARY}
+ ${AZURE_STORAGE_BLOBS_STATIC_LIBRARY}
+ ${AZURE_STORAGE_COMMON_STATIC_LIBRARY}
+
${AZURE_STORAGE_FILES_DATALAKE_STATIC_LIBRARY}
+ DEPENDS azure_sdk_dependencies)
+ add_library(Azure::azure-core STATIC IMPORTED)
+ set_target_properties(Azure::azure-core
+ PROPERTIES IMPORTED_LOCATION
${AZURE_CORE_STATIC_LIBRARY}
+ INTERFACE_INCLUDE_DIRECTORIES
+ ${AZURESDK_INCLUDE_DIR})
+ set_property(TARGET Azure::azure-core
+ PROPERTY INTERFACE_LINK_LIBRARIES CURL::libcurl OpenSSL::Crypto
OpenSSL::SSL)
+ add_dependencies(Azure::azure-core azuresdk_ep)
+
+ add_library(Azure::azure-identity STATIC IMPORTED)
+ set_target_properties(Azure::azure-identity
+ PROPERTIES IMPORTED_LOCATION
${AZURE_IDENTITY_STATIC_LIBRARY}
+ INTERFACE_INCLUDE_DIRECTORIES
+ ${AZURESDK_INCLUDE_DIR})
+ set_property(TARGET Azure::azure-identity
+ PROPERTY INTERFACE_LINK_LIBRARIES OpenSSL::Crypto
Azure::azure-core)
Review Comment:
Thanks.
It seems that azure-core doesn't depend on `OpenSSL::Crypto`:
https://github.com/Azure/azure-sdk-for-cpp/blob/c2b2d565794c53992d1523ddb4df77a3292df628/sdk/core/azure-core/CMakeLists.txt#L178
How about the followings?
* `Azure::azure-core` depends on only `CURL::libcurl` and `OpenSSL::SSL`
* `Azure::azure-identity` depends on `Azure::azure-core` and
`OpenSSL::Crypto`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
