kou commented on a change in pull request #9045: URL: https://github.com/apache/arrow/pull/9045#discussion_r550695044
########## File path: .pre-commit-config.yaml ########## @@ -40,9 +40,10 @@ repos: - id: cmake-format name: CMake Format language: python - entry: bash -c "pip install cmake-format && python run-cmake-format.py --check" - entry: echo - files: ^(.*/CMakeLists.txt|.*.cmake)$ + entry: cmake-format --in-place --autosort=false + files: CMakeLists\.txt$|^cpp/cmake_modules/ + additional_dependencies: + - cmake_format==0.6.13 Review comment: Why do you specify `0.6.13`? We're using 0.5.2 as I said at https://github.com/apache/arrow/pull/9045#discussion_r550335310 . Anyway, we can't merge this until we fix the following issues: * https://github.com/apache/arrow/pull/9045#issuecomment-752475426 * https://github.com/apache/arrow/pull/9045/checks?check_run_id=1629598956 Could you fix them? ########## File path: .pre-commit-config.yaml ########## @@ -40,9 +40,10 @@ repos: - id: cmake-format name: CMake Format language: python - entry: bash -c "pip install cmake-format && python run-cmake-format.py --check" - entry: echo - files: ^(.*/CMakeLists.txt|.*.cmake)$ + entry: cmake-format --in-place --autosort=false Review comment: I couldn't reproduce the difference on my environment: ```console $ time pre-commit run cmake-format --all-files [WARNING] Unexpected key(s) present on git://github.com/pre-commit/pre-commit-hooks: sha CMake Format.............................................................Passed real 0m3.476s user 0m13.000s sys 0m0.297s $ time python3 run-cmake-format.py real 0m1.358s user 0m1.308s sys 0m0.046s ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org