ianmcook commented on PR #36739: URL: https://github.com/apache/arrow/pull/36739#issuecomment-1680699604
> > I think it is possible to define 2 explicit public functions of the class SetLookupOptions: > > SetLookupOptions(Datum value_set, bool skip_nulls = false) (same as currently) > > SetLookupOptions(Datum value_set, NullMatchingBehavior null_matching_behavior = NullMatchingBehavior::MATCH) > > Hi @ianmcook, do you mean we remove the member variable `skip_nulls` and make it a parameter in constructor function and then translate the `skip_nulls` to `NullMatchingBehavior` ? > > I think this way will affect some users who set `skip_nulls` directly via member variable. Does it ok? Yes, I think this is OK. We can mark this as a breaking change if needed, but I think it should not affect most users. @westonpace or @bkietz can you please confirm? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
