alamb commented on issue #7298: URL: https://github.com/apache/arrow-datafusion/issues/7298#issuecomment-1680978853
Relevant comment from @devinjdangelo on https://github.com/apache/arrow-datafusion/pull/7283#discussion_r1295116687: > This raises an interesting question about the desired behavior in this scenario. If the options specify an irrelevant setting (row_group_size for a json setting), should DataFusion: > > Ignore the irrelevant setting (current behavior) > Ignore the irrelevant setting but emit a warning > Raise an error and refuse to execute the query entirely I personally think returning an error and refuse the execute the query is the most user friendly thing to do -- that way user mistakes or typo/misspellings of the option will be caught quickly rather than being masked. A warning would also be ok, but many places DataFusion is used don't necessarily have a way to sending warnings back to the user (e.g. the warnings may end up in a server log somewhere) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
