alamb commented on code in PR #7321:
URL: https://github.com/apache/arrow-datafusion/pull/7321#discussion_r1298340000
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -192,39 +198,48 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
}
SQLExpr::ArrayIndex { obj, indexes } => {
- let expr = self.sql_expr_to_logical_expr(*obj, schema,
planner_context)?;
+ let expr =
Review Comment:
it is interesting that this file was reformatted without changes 🤔
##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -1369,9 +1369,9 @@ mod tests {
lit("abcde"),
lit(ScalarValue::Int8(Some(2))),
],
- Err(DataFusionError::Internal(
- "function left requires compilation with feature flag:
unicode_expressions.".to_string()
- )),
+ internal_err!(
Review Comment:
This wasn't caused by this PR, but it almost seems like these should be
`plan_err!` rather than `internal_err!` (though maybe they are internal because
this should have been checked earlier
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -192,39 +198,48 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
}
SQLExpr::ArrayIndex { obj, indexes } => {
- let expr = self.sql_expr_to_logical_expr(*obj, schema,
planner_context)?;
+ let expr =
Review Comment:
it is interesting that this file was reformatted without changes 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
