alamb opened a new pull request, #7355: URL: https://github.com/apache/arrow-datafusion/pull/7355
## Which issue does this PR close? related to #6108 and https://github.com/apache/arrow-datafusion/issues/7326 related to https://github.com/apache/arrow-datafusion/pull/7339/ ## Rationale for this change While trying to clean up a comment I saw left over from https://github.com/apache/arrow-datafusion/pull/7339 I realized that not only are the comments in the rest of this file misleading the same bug also applied. Specifically, despite the comments' claims that "this should have been covered earlier" it is clearly not and these error paths are directly user visible due to invalid queries (and thus should be plan errors, not internal errors): ``` DataFusion CLI v29.0.0 ❯ select encode(1,2); Internal error: The encode function can only accept utf8 or binary.. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker ❯ select array_concat(1,2); Internal error: The array_concat function can only accept list as the args.. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker ``` ## What changes are included in this PR? 1. Change to DataFusionError::Plan 2. Update tests 3. Update comments ## Are these changes tested? Yes ## Are there any user-facing changes? yes, better error messages <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
