wgtmac commented on code in PR #36574:
URL: https://github.com/apache/arrow/pull/36574#discussion_r1302537048
##########
cpp/src/parquet/page_index.h:
##########
@@ -332,7 +340,8 @@ class PARQUET_EXPORT OffsetIndexBuilder {
class PARQUET_EXPORT PageIndexBuilder {
public:
/// \brief API convenience to create a PageIndexBuilder.
- static std::unique_ptr<PageIndexBuilder> Make(const SchemaDescriptor*
schema);
+ static std::unique_ptr<PageIndexBuilder> Make(const SchemaDescriptor* schema,
+ InternalFileEncryptor*
file_encryptor);
Review Comment:
OK, I prefer the latter which does not have a default parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
