alamb commented on code in PR #7375:
URL: https://github.com/apache/arrow-datafusion/pull/7375#discussion_r1303392720
##########
datafusion/common/src/scalar.rs:
##########
@@ -2072,53 +1188,48 @@ impl ScalarValue {
}
}
+ /// Wrapping addition of `ScalarValue`
+ ///
+ /// NB: operating on `ScalarValue` directly is not efficient, performance
sensitive code
Review Comment:
I like the performance admonition 👍
##########
datafusion/common/src/scalar.rs:
##########
@@ -2072,53 +1188,48 @@ impl ScalarValue {
}
}
+ /// Wrapping addition of `ScalarValue`
+ ///
+ /// NB: operating on `ScalarValue` directly is not efficient, performance
sensitive code
Review Comment:
I like the performance admonition 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
