js8544 commented on issue #37055: URL: https://github.com/apache/arrow/issues/37055#issuecomment-1690920363
> I'm not entirely sure I understand the goal. Sorry I wasn't clear enough. As discussed [here](https://github.com/apache/arrow/pull/9683#issuecomment-800442398), there are two ways to implement the `value_counts` kernel for Dictionary inputs. The current implementation uses the first approach, but we want to switch to the second for better performance. However, we would need to call `hash_count` within the `value_counts` kernel. There used to be a `internal::GroupBy` available, but I am not sure if that's possible now after the refactoring. To be clear, I'm talking about kernel implementation in C++, not user's code in Python. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
