mathyingzhou commented on a change in pull request #8648: URL: https://github.com/apache/arrow/pull/8648#discussion_r550990362
########## File path: cpp/src/arrow/adapters/orc/adapter.h ########## @@ -19,14 +19,38 @@ #include <cstdint> #include <memory> +#include <sstream> #include <vector> +#include "arrow/io/file.h" #include "arrow/io/interfaces.h" #include "arrow/memory_pool.h" #include "arrow/record_batch.h" #include "arrow/status.h" #include "arrow/type.h" #include "arrow/util/visibility.h" +#include "orc/OrcFile.hh" + +namespace liborc = orc; + +#define ORC_THROW_NOT_OK(s) \ Review comment: These macros aren't actually allowed in adapter.h hence they have been removed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org