kou commented on code in PR #36835:
URL: https://github.com/apache/arrow/pull/36835#discussion_r1306566738
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -5049,6 +5067,56 @@ if(ARROW_S3)
endif()
endif()
+# ----------------------------------------------------------------------
+# Azure SDK for C++
+
+function(build_azure_sdk)
+ message(STATUS "Building Azure SDK for C++ from source")
+ fetchcontent_declare(azure_sdk
+ URL ${ARROW_AZURE_SDK_URL}
+ URL_HASH
"SHA256=${ARROW_AZURE_SDK_BUILD_SHA256_CHECKSUM}")
+ set(BUILD_PERFORMANCE_TESTS FALSE)
+ set(BUILD_SAMPLES FALSE)
+ set(BUILD_TESTING FALSE)
+ set(BUILD_WINDOWS_UWP TRUE)
+ set(CMAKE_EXPORT_NO_PACKAGE_REGISTRY TRUE)
+ set(DISABLE_AZURE_CORE_OPENTELEMETRY TRUE)
+ set(ENV{AZURE_SDK_DISABLE_AUTO_VCPKG} TRUE)
+ set(WARNINGS_AS_ERRORS FALSE)
+ # TODO: Configure flags in a better way. FetchContent builds inherit
+ # global flags but we want to disable -Werror for Azure SDK for C++ builds.
Review Comment:
Fix a lint failure:
```suggestion
# TODO: Configure flags in a better way. FetchContent builds inherit
# global flags but we want to disable -Werror for Azure SDK for C++ builds.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
