jeremyosterhoudt commented on code in PR #37441: URL: https://github.com/apache/arrow/pull/37441#discussion_r1309474507
########## docs/source/status.rst: ########## @@ -243,47 +243,51 @@ support/not support individual features. +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ | CancelQuery | ✓ | ✓ | | | | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| ClosePreparedStatement | ✓ | ✓ | ✓ | | | | | | +| ClosePreparedStatement | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| CreatePreparedStatement | ✓ | ✓ | ✓ | | | | | | +| CreatePreparedStatement | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ | CreatePreparedSubstraitPlan | ✓ | ✓ | | | | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ | EndSavepoint | ✓ | ✓ | | | | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ | EndTransaction | ✓ | ✓ | | | | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| GetCatalogs | ✓ | ✓ | ✓ | | | | | | +| GetCatalogs | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| GetCrossReference | ✓ | ✓ | ✓ | | | | | | +| GetCrossReference | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| GetDbSchemas | ✓ | ✓ | ✓ | | | | | | +| GetDbSchemas | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| GetExportedKeys | ✓ | ✓ | ✓ | | | | | | +| GetExportedKeys | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| GetImportedKeys | ✓ | ✓ | ✓ | | | | | | +| GetImportedKeys | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| GetPrimaryKeys | ✓ | ✓ | ✓ | | | | | | +| GetPrimaryKeys | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| GetSqlInfo | ✓ | ✓ | ✓ | | | | | | +| GetSqlInfo | ✓ | ✓ | ✓ | | ✓ (1) | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| GetTables | ✓ | ✓ | ✓ | | | | | | +| GetTables | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| GetTableTypes | ✓ | ✓ | ✓ | | | | | | +| GetTableTypes | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| GetXdbcTypeInfo | ✓ | ✓ | ✓ | | | | | | +| GetXdbcTypeInfo | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| PreparedStatementQuery | ✓ | ✓ | ✓ | | | | | | +| PreparedStatementQuery | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| PreparedStatementUpdate | ✓ | ✓ | ✓ | | | | | | +| PreparedStatementUpdate | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ | StatementSubstraitPlan | ✓ | ✓ | | | | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| StatementQuery | ✓ | ✓ | ✓ | | | | | | +| StatementQuery | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ -| StatementUpdate | ✓ | ✓ | ✓ | | | | | | +| StatementUpdate | ✓ | ✓ | ✓ | | ✓ | | | | +--------------------------------------------+-------+-------+-------+------------+-------+-------+-------+-------+ +Notes: + +* \(1) GetSqlInfo filtering is not currently supported in C#. Review Comment: Sorry about that I was mixing up our implementation with the base support provided by Arrow Flight SQL. Our implementation doesn't allow a `CommandGetSqlInfo` `Info` field to be populated when the command is executed. I've seen implementations in other languages where the `Info` field is used as a metadata filter list. However, the C# base implementation does not impose any restrictions. I fixed the documentation. Thanks for the catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
