js8544 commented on code in PR #37243:
URL: https://github.com/apache/arrow/pull/37243#discussion_r1310409338
##########
cpp/src/arrow/compute/kernels/aggregate_basic_internal.h:
##########
@@ -196,20 +203,32 @@ struct MeanImpl : public SumImpl<ArrowType, SimdLevel> {
}
return Status::OK();
}
+
+ Status Finalize(KernelContext*, Datum* out) override { return
FinalizeImpl(out); }
+};
+
+template <typename ArrowType, SimdLevel::type SimdLevel>
+struct MeanImpl<ArrowType, SimdLevel,
+ std::enable_if_t<!is_decimal_type<ArrowType>::value>>
+ : public SumImpl<ArrowType, SimdLevel, DoubleType> {
Review Comment:
Done and rebased from main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
