tustvold commented on code in PR #4751:
URL: https://github.com/apache/arrow-rs/pull/4751#discussion_r1310467474
##########
arrow/src/pyarrow.rs:
##########
@@ -277,10 +278,19 @@ impl FromPyArrow for ArrowArrayStreamReader {
}
}
-impl IntoPyArrow for ArrowArrayStreamReader {
+impl FromPyArrow for Box<dyn RecordBatchReader + Send> {
Review Comment:
What is the advantage of this over just using ArrowArrayStreamReader
directly?
As an aside we should probably document this method better, it isn't
immediately clear it can be passed a pyarrow RecordBatchReader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
