korowa opened a new pull request, #7459:
URL: https://github.com/apache/arrow-datafusion/pull/7459
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #7254.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Show physical plan operators statistics in `explain [analyze] [verbose]`
output.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
1) `DisplayableExecutionPlan` now is able to display statistics for both
ident (default text) and graphviz formats -- behaviour is controlled by `show
statistics` field, which is implicitly set in explain handler and explain
analyze operator
2) `datafusion.explain.show_statistics` setting, disabled by default --
controls display statistics behaviour
New setting is sort of questionable , but as for now, execution plan
comparisons are widely used while testing across multiple DF packages, and
possible alternatives could be to keep plans as they are with statistics (which
could lead to frequent adjustments of expected plan values in case of any
statistics-related modifications) or building common plan normalizer for
replacing actual statistics with a placeholders (seems to be unnecessary
dependency for tests). So, any suggestions are welcome here!
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Covered by sqllogictests for explain & unit tests for `explain analyze` and
graphviz format.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
Availability of statistics in `explain` output
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
