kou commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1314161810
##########
python/CMakeLists.txt:
##########
@@ -706,6 +706,14 @@ endif()
# Error on any warnings not already explicitly ignored.
set(CYTHON_FLAGS "${CYTHON_FLAGS}" "--warning-errors")
+if(PYARROW_BUILD_PARQUET_ENCRYPTION)
+ message(STATUS "Parquet Encryption Enabled")
+ list(APPEND CYTHON_FLAGS "-E PARQUET_ENCRYPTION_ENABLED=1")
+else()
+ message(STATUS "Parquet Encryption is NOT Enabled")
+ list(APPEND CYTHON_FLAGS "-E PARQUET_ENCRYPTION_ENABLED=0")
Review Comment:
```suggestion
list(APPEND CYTHON_FLAGS "-E" "PARQUET_ENCRYPTION_ENABLED=0")
```
##########
python/CMakeLists.txt:
##########
@@ -706,6 +706,14 @@ endif()
# Error on any warnings not already explicitly ignored.
set(CYTHON_FLAGS "${CYTHON_FLAGS}" "--warning-errors")
+if(PYARROW_BUILD_PARQUET_ENCRYPTION)
+ message(STATUS "Parquet Encryption Enabled")
+ list(APPEND CYTHON_FLAGS "-E PARQUET_ENCRYPTION_ENABLED=1")
Review Comment:
```suggestion
list(APPEND CYTHON_FLAGS "-E" "PARQUET_ENCRYPTION_ENABLED=1")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
