ritchie46 commented on code in PR #4765:
URL: https://github.com/apache/arrow-rs/pull/4765#discussion_r1314805208
##########
parquet/Cargo.toml:
##########
@@ -42,7 +42,7 @@ arrow-csv = { workspace = true, optional = true }
arrow-data = { workspace = true, optional = true }
arrow-schema = { workspace = true, optional = true }
arrow-select = { workspace = true, optional = true }
-arrow-ipc = { workspace = true, optional = true }
+arrow-ipc = { workspace = true, default-features = false, optional = true }
Review Comment:
You mean during development time? I don't really understand. Seems a single
compilation pass per crate. Recompiling both afterwards is cached.
<details>
```c
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs$ cd arrow-ipc/
(base)
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs/arrow-ipc$ cargo
c (base)
Checking libm v0.2.7
Checking cfg-if v1.0.0
Compiling libc v0.2.147
Checking static_assertions v1.1.0
Checking bytes v1.4.0
Checking arrow-schema v46.0.0
(/home/ritchie46/code/arrow-rs/arrow-schema)
Checking iana-time-zone v0.1.57
Checking once_cell v1.18.0
Checking hashbrown v0.14.0
Checking bitflags v1.3.2
Checking lexical-util v0.8.5
Checking flatbuffers v23.5.26
Checking num-traits v0.2.16
Checking lexical-write-integer v0.8.5
Checking lexical-parse-integer v0.8.6
Checking lexical-write-float v0.8.5
Checking lexical-parse-float v0.8.5
Checking getrandom v0.2.10
Checking num-integer v0.1.45
Checking num-complex v0.4.4
Checking half v2.3.1
Checking chrono v0.4.28
Checking ahash v0.8.3
Checking num-bigint v0.4.4
Checking num-iter v0.1.43
Checking lexical-core v0.8.5
Checking num-rational v0.4.1
Checking num v0.4.1
Checking arrow-buffer v46.0.0
(/home/ritchie46/code/arrow-rs/arrow-buffer)
Checking arrow-data v46.0.0 (/home/ritchie46/code/arrow-rs/arrow-data)
Checking arrow-array v46.0.0 (/home/ritchie46/code/arrow-rs/arrow-array)
Checking arrow-select v46.0.0
(/home/ritchie46/code/arrow-rs/arrow-select)
Checking arrow-cast v46.0.0 (/home/ritchie46/code/arrow-rs/arrow-cast)
Checking arrow-ipc v46.0.0 (/home/ritchie46/code/arrow-rs/arrow-ipc)
Finished dev [unoptimized + debuginfo] target(s) in 13.10s
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs/arrow-ipc$ cd ..
(base)
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs$ cd parquet
(base)
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs/parquet$ cargo c
(base)
Checking libc v0.2.147
Checking alloc-no-stdlib v2.0.4
Checking adler v1.0.2
Checking byteorder v1.4.3
Checking integer-encoding v3.0.4
Checking twox-hash v1.6.3
Checking base64 v0.21.3
Checking crc32fast v1.3.2
Checking chrono v0.4.28
Checking ordered-float v2.10.0
Checking snap v1.1.0
Checking alloc-stdlib v0.2.2
Checking miniz_oxide v0.7.1
Checking brotli-decompressor v2.3.4
Checking thrift v0.17.0
Checking getrandom v0.2.10
Checking zstd-sys v2.0.8+zstd.1.5.5
Checking lz4-sys v1.9.4
Checking flate2 v1.0.27
Checking lz4 v1.24.0
Checking ahash v0.8.3
Checking zstd-safe v6.0.6
Checking zstd v0.12.4
Checking arrow-array v46.0.0 (/home/ritchie46/code/arrow-rs/arrow-array)
Checking brotli v3.3.4
Checking arrow-select v46.0.0
(/home/ritchie46/code/arrow-rs/arrow-select)
Checking arrow-cast v46.0.0 (/home/ritchie46/code/arrow-rs/arrow-cast)
Checking arrow-ipc v46.0.0 (/home/ritchie46/code/arrow-rs/arrow-ipc)
Checking parquet v46.0.0 (/home/ritchie46/code/arrow-rs/parquet)
Finished dev [unoptimized + debuginfo] target(s) in 9.00s
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs/parquet$ cd ..
(base)
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs$ cd arrow-ipc/
(base)
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs/arrow-ipc$ cargo
c (base)
Finished dev [unoptimized + debuginfo] target(s) in 0.22s
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs/arrow-ipc$ cd ..
(base)
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs$ arrow/^C
(base)
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs$ cd parquet
(base)
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs/parquet$ cargo c
(base)
Finished dev [unoptimized + debuginfo] target(s) in 0.28s
[features_parquet] ritchie46 /home/ritchie46/code/arrow-rs/parquet$
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
