jonkeane commented on a change in pull request #9092:
URL: https://github.com/apache/arrow/pull/9092#discussion_r551549190
##########
File path: r/R/record-batch.R
##########
@@ -274,6 +274,12 @@ as.data.frame.RecordBatch <- function(x, row.names = NULL,
optional = FALSE, ...
}
.serialize_arrow_r_metadata <- function(x) {
+ # drop problems attributes (most likely from readr)
+ if ("attributes" %in% names(x) &&
+ "problems" %in% names(x[["attributes"]]) ) {
+ x[["attributes"]][["problems"]] <- NULL
+ }
+
Review comment:
Yeah I can do that. Though [one of the existing
tests](https://github.com/apache/arrow/blob/master/r/tests/testthat/test-metadata.R#L76-L81)
fails here — the one right above it works which might be sufficient, is there
something that lines 76-81 is testing that we aren't covering with lines 70-75?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
