zeroshade commented on code in PR #37503:
URL: https://github.com/apache/arrow/pull/37503#discussion_r1315999493
##########
go/parquet/pqarrow/column_readers.go:
##########
@@ -833,12 +888,51 @@ func transferDecimalBytes(rdr file.BinaryRecordReader, dt
arrow.DataType) (*arro
}
ret := array.NewData(dt, length, []*memory.Buffer{
- input.Data().Buffers()[0], memory.NewBufferBytes(data),
+ in.Data().Buffers()[0], memory.NewBufferBytes(data),
}, nil, nullCount, 0)
defer ret.Release()
return array.MakeFromData(ret), nil
}
+ convert256 := func(in varOrFixedBin) (arrow.Array, error) {
+ length := in.Len()
+ data := make([]byte,
arrow.Decimal256Traits.BytesRequired(length))
+ out := arrow.Decimal256Traits.CastFromBytes(data)
+
+ nullCount := in.NullN()
+ var err error
+ for i := 0; i < length; i++ {
+ if nullCount > 0 && in.IsNull(i) {
+ continue
+ }
+
+ rec := in.Value(i)
+ if len(rec) <= 0 {
+ return nil, fmt.Errorf("invalud BYTEARRAY
length for type: %s", dt)
Review Comment:
nice catch! thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
