yordan-pavlov commented on a change in pull request #9064: URL: https://github.com/apache/arrow/pull/9064#discussion_r551574592
########## File path: rust/datafusion/src/physical_plan/parquet.rs ########## @@ -209,6 +251,479 @@ impl ParquetExec { } } +#[derive(Debug, Clone)] +/// Predicate builder used for generating of predicate functions, used to filter row group metadata +pub struct PredicateExpressionBuilder { Review comment: thinking some more about this, it could be done by moving the creation of PredicateExpressionBuilder from `ParquetExec::try_from_files` into `(ExecutionPlan for ParquetExec)::execute`, but then this work would be repeated for each partition, where as currently it's only done once; at this point I don't think it's worth it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org