pitrou commented on a change in pull request #9100:
URL: https://github.com/apache/arrow/pull/9100#discussion_r551852896
##########
File path: cpp/src/arrow/util/trie_test.cc
##########
@@ -175,6 +175,15 @@ TEST(Trie, EmptyString) {
ASSERT_EQ(-1, trie.Find("x"));
}
+TEST(Trie, LongString) {
+ TrieBuilder builder;
+ ASSERT_OK(builder.Append(""));
+ const Trie trie = builder.Finish();
+ auto maxlen = static_cast<size_t>(std::numeric_limits<int16_t>::max()) + 1;
Review comment:
We may want to test with a bunch of limit-case sizes (e.g. `2^n, 2^n-1,
2^n+1` for `n` in 15, 16, 17).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
