tustvold commented on code in PR #7514:
URL: https://github.com/apache/arrow-datafusion/pull/7514#discussion_r1320548343
##########
datafusion/common/src/scalar.rs:
##########
@@ -431,122 +387,6 @@ impl PartialOrd for ScalarValue {
}
}
-/// This function computes the duration (in milliseconds) of the given
Review Comment:
These functions are somewhat misleading as it is not clearly conveyed that
they are a gross approximation, assuming certain numbers of days in months,
etc... Given these don't appear to be used elsewhere, I think the best option
is to remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
