pitrou commented on a change in pull request #9023:
URL: https://github.com/apache/arrow/pull/9023#discussion_r551989364
##########
File path: cpp/src/arrow/compute/kernels/common.h
##########
@@ -19,6 +19,7 @@
// IWYU pragma: begin_exports
+#include <cmath>
Review comment:
We only add inclusion in header files when it is required by the header
file itself, otherwise it would inflate compilation times for nothing.
Admittedly, `cmath` is probably not a large file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
