fatemehp commented on issue #37559:
URL: https://github.com/apache/arrow/issues/37559#issuecomment-1718057111

   Thanks a lot @mapleFU for putting together the doc. It is very helpful.
   
   A few comments:
   
   * I think we have decisions to make in multiple dimensions: 1) Filter 
expression/parsing 2) Filter pushdown 3) Filter evaluation 4) Types of filters 
to support (equality, range, etc). It would be nice to call these out to make 
it clear.
   
   * We might want to split the new features into basic and more advanced 
features and give them an order of how we are going to support them. For 
example, we might want to first support equality predicates and then later 
range predicates. Also, pushing down selection vectors to various decoders 
seems to be more advanced and will come after pushing down the row ranges.
   
   * Could we also clarify what we are going to do about the filter evaluation? 
Are we going to ask the caller to evaluate the filter on each row and return a 
boolean? Or are we going to implement/use some sort of evaluation library?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to