mapleFU commented on code in PR #37754:
URL: https://github.com/apache/arrow/pull/37754#discussion_r1328042525
##########
cpp/src/arrow/array/dict_internal.h:
##########
@@ -91,11 +92,10 @@ struct DictionaryTraits<T, enable_if_has_c_type<T>> {
using c_type = typename T::c_type;
using MemoTableType = typename HashTraits<T>::MemoTableType;
- static Status GetDictionaryArrayData(MemoryPool* pool,
- const std::shared_ptr<DataType>& type,
- const MemoTableType& memo_table,
- int64_t start_offset,
- std::shared_ptr<ArrayData>* out) {
+ static Result<std::shared_ptr<ArrayData>> GetDictionaryArrayData(
+ MemoryPool* pool, const std::shared_ptr<DataType>& type,
+ const MemoTableType& memo_table, int64_t start_offset,
+ std::shared_ptr<ArrayData>* out) {
Review Comment:
ditto
##########
cpp/src/arrow/array/dict_internal.h:
##########
@@ -63,11 +64,10 @@ struct DictionaryTraits<BooleanType> {
using T = BooleanType;
using MemoTableType = typename HashTraits<T>::MemoTableType;
- static Status GetDictionaryArrayData(MemoryPool* pool,
- const std::shared_ptr<DataType>& type,
- const MemoTableType& memo_table,
- int64_t start_offset,
- std::shared_ptr<ArrayData>* out) {
+ static Result<std::shared_ptr<ArrayData>> GetDictionaryArrayData(
+ MemoryPool* pool, const std::shared_ptr<DataType>& type,
+ const MemoTableType& memo_table, int64_t start_offset,
+ std::shared_ptr<ArrayData>* out) {
Review Comment:
can we remove this `out` ( because it's an output argument?) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
