ianmcook commented on code in PR #36739:
URL: https://github.com/apache/arrow/pull/36739#discussion_r1330410134
##########
cpp/src/arrow/compute/api_scalar.h:
##########
@@ -268,19 +268,45 @@ class ARROW_EXPORT ExtractRegexOptions : public
FunctionOptions {
/// Options for IsIn and IndexIn functions
class ARROW_EXPORT SetLookupOptions : public FunctionOptions {
public:
- explicit SetLookupOptions(Datum value_set, bool skip_nulls = false);
+ enum NullMatchingBehavior { MATCH, SKIP, EMIT_NULL, INCONCLUSIVE };
Review Comment:
To ensure that this renders cleanly at
https://arrow.apache.org/docs/dev/cpp/api/compute.html, I think the
descriptions should be moved into comment lines here, inside the enum
definition.
Here is an example of this:
https://github.com/apache/arrow/blob/3b646ad4c2b826fe08b31d19e6435f73650bcb5e/cpp/src/arrow/compute/api_scalar.h#L171-L182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
