alamb commented on code in PR #7605:
URL: https://github.com/apache/arrow-datafusion/pull/7605#discussion_r1331423859
##########
datafusion/physical-plan/src/lib.rs:
##########
@@ -74,7 +74,11 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// If the plan does not support pipelining, but its input(s) are
/// infinite, returns an error to indicate this.
fn unbounded_output(&self, _children: &[bool]) -> Result<bool> {
- Ok(false)
+ if _children.iter().any(|&x| x) {
+ plan_err!("Plan does not support infinite stream from its
children")
Review Comment:
While I was surprised initially that this function would return an error,
this change seems to make the code match the API described in the comments so 👍
##########
datafusion/physical-plan/src/lib.rs:
##########
@@ -74,7 +74,11 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
/// If the plan does not support pipelining, but its input(s) are
/// infinite, returns an error to indicate this.
fn unbounded_output(&self, _children: &[bool]) -> Result<bool> {
- Ok(false)
+ if _children.iter().any(|&x| x) {
+ plan_err!("Plan does not support infinite stream from its
children")
Review Comment:
While I was surprised initially that this function would return an error,
this change seems to make the code match the API described in the comments so 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
