bkietz commented on code in PR #36739:
URL: https://github.com/apache/arrow/pull/36739#discussion_r1331547237
##########
cpp/src/arrow/compute/api_scalar.cc:
##########
@@ -344,7 +367,8 @@ static auto kRoundToMultipleOptionsType =
GetFunctionOptionsType<RoundToMultiple
DataMember("round_mode", &RoundToMultipleOptions::round_mode));
static auto kSetLookupOptionsType = GetFunctionOptionsType<SetLookupOptions>(
DataMember("value_set", &SetLookupOptions::value_set),
- DataMember("skip_nulls", &SetLookupOptions::skip_nulls));
+ DataMember("skip_nulls", &SetLookupOptions::skip_nulls),
+ DataMember("null_matching_behavior",
&SetLookupOptions::null_matching_behavior));
Review Comment:
Ah, sorry. I didn't correct the return type of `get()`
```c++
template <typename C, typename T>
struct CoercedDataMemberProperty {
using Class = C;
using Type = T;
constexpr Type get(const Class& obj) const { return (obj.*get_coerced_)();
}
void set(Class* obj, Type value) const { (*obj).*ptr_for_set_ =
std::move(value); }
constexpr std::string_view name() const { return name_; }
std::string_view name_;
Type Class::*ptr_for_set_;
Type (Class::*get_coerced_)() const;
};
template <typename Class, typename Type>
constexpr CoercedDataMemberProperty<Class, Type>
CoercedDataMember(std::string_view name,
Type
Class::*ptr,
Type
(Class::*get)()
const) {
return {name, ptr, get};
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
