zhztheplayer commented on pull request #7030: URL: https://github.com/apache/arrow/pull/7030#issuecomment-755898896
@pitrou I've moved the pool class out to jni_wrapper.cpp. I saw your comments in https://issues.apache.org/jira/browse/ARROW-11143, thanks for that. Regarding the static variables, I was just following current patterns in modules like gandiva-jni. Is there a better practice for this? Should we factor them out to specific namespaces (maybe in other tickets)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
