jonmmease commented on PR #7633: URL: https://github.com/apache/arrow-datafusion/pull/7633#issuecomment-1733693651
Thanks for the review and for trying it out @alamb! I think moving the wasmtest crate to an example makes sense. I'll take a look at doing that later today. > Though it does take a non trivial amount of time 🤔 One thing I can do is change `wasm-pack build` to `wasm-pack build --dev`, which disables the use of `wasm-opt` which takes a bit of time to optimize the resulting wasm binary. > Also, Maybe it would be worth adding a ticket to track getting all of datafusion running in the browser 🤔 I tried disabling the default parquet features locally, and I did get things compiling. But unfortunately I wasn't able to successfully construct a `SessionContext` without panicing. I didn't get too far into investigating this, but I think one of this issues is that `std::time::Instant::now()` isn't compatible with WASM by default (See https://internals.rust-lang.org/t/is-std-instant-on-webassembly-possible/18913), though there are replacements available [in other crates](https://docs.rs/wasm-timer/latest/wasm_timer/struct.Instant.html). It would be great to get to the point of being able to use all of DataFusion in the browser, similarly to [DuckDB-Wasm](https://duckdb.org/2021/10/29/duckdb-wasm.html). But my sense is that there's still a fair bit of work required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
