CurtHagenlocher commented on PR #37388: URL: https://github.com/apache/arrow/pull/37388#issuecomment-1734781255
I also could go either way. It's hard to predict the kind of scenarios that people might care about but I think the lower precision of DateTime vs nanos makes it a suboptimal fit anyway. Users who need the performance could do the conversion on the outside and then use the overload for appending an int64 directly. That said, there are other places in the code where multiplication happens e.g. GetTimestampUnchecked (for a different meaning of "unchecked") and I don't know how to describe a policy for when these should be checked and when they shouldn't be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
