jorisvandenbossche commented on code in PR #36846:
URL: https://github.com/apache/arrow/pull/36846#discussion_r1336944831
##########
python/pyarrow/types.pxi:
##########
@@ -2014,6 +2014,48 @@ cpdef KeyValueMetadata ensure_metadata(object meta,
c_bool allow_none=False):
return KeyValueMetadata(meta)
+cdef class FieldMergeOptions(_Weakrefable):
+ """
+ Options controlling how to merge the types of two fields.
+
+ By default, types must match exactly, except the null type can be
+ merged with any other type.
+
+ """
+
+ cdef:
+ CField.CMergeOptions c_options
+
+ __slots__ = ()
+
+ def __init__(self, *):
+ self.c_options = CField.CMergeOptions.Defaults()
Review Comment:
> Keep in mind that the `concat_tables` will try to match the schema of the
first table,
I think when `promote=True` is specified (which translates to
`unify_schemas=True` on the C++ side), we actually do unify the schemas of all
input tables first, and so not just take the schema of the first input? (the
text about the first table is only to determine which schema _metadata_ to use
for the return value)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
