zeroshade commented on code in PR #37785:
URL: https://github.com/apache/arrow/pull/37785#discussion_r1337352462
##########
go/parquet/internal/bmi/bmi_arm64.go:
##########
@@ -14,44 +14,51 @@
// See the License for the specific language governing permissions and
// limitations under the License.
+//go:build !noasm
// +build !noasm
package bmi
import (
+ "fmt"
"os"
"strings"
-)
-import (
- "golang.org/x/sys/cpu"
Review Comment:
From what I could tell in my testing, it appears that on `golang1.20` and
below, it was ending up false on arm64 platforms when it shouldn't. Try testing
it on `golang1.20` instead of 1.21 and let me know, because that's what I was
observing in my tests (and explains why we never caught this issue before now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
