westonpace commented on PR #37868: URL: https://github.com/apache/arrow/pull/37868#issuecomment-1737619231
> But that request you linked is also problematic with regards to threading Can you expand on this? > By the way, -1 is a bit misleading here... There is a `kNoSize` constant in `filesystem.h` that could be used in a few places but I don't know how much clearer that makes things. We are on C++17 now so we can use https://en.cppreference.com/w/cpp/utility/optional but that would be a considerably more significant refactor. I think -1 / kNoSize is probably ok for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
