alamb commented on a change in pull request #9025:
URL: https://github.com/apache/arrow/pull/9025#discussion_r553434218
##########
File path: rust/arrow/src/datatypes.rs
##########
@@ -1500,6 +1590,7 @@ impl Field {
}
/// Merge field into self if it is compatible. Struct will be merged
recursively.
+ /// NOTE: `self` may be updated to unexpected state in case of merge
failure.
Review comment:
I think this "good now, better later" strategy is a good one. I agree
with @nevi-me 's suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
