Dandandan commented on a change in pull request #9129:
URL: https://github.com/apache/arrow/pull/9129#discussion_r553473279
##########
File path: rust/arrow/src/compute/kernels/sort.rs
##########
@@ -42,6 +42,8 @@ pub fn sort(values: &ArrayRef, options: Option<SortOptions>)
-> Result<ArrayRef>
}
// sorts f32 in IEEE 754 total ordering
Review comment:
Maybe "sorts" wasn't also the best way to describe it. Maybe `implements
comparison using IEEE 754 total ordering`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]