Re: [PR] preserve array type / timezone in `date_bin` and `date_trunc` functions [arrow-datafusion]

[via GitHub]

mhilton commented on code in PR #7729:
URL: https://github.com/apache/arrow-datafusion/pull/7729#discussion_r1345418457


##########
datafusion/physical-expr/src/datetime_expressions.rs:
##########
@@ -1051,6 +1077,91 @@ mod tests {
         });
     }
 
+    #[test]
+    fn test_date_trunc_timezones() {
+        let cases = vec![
+            (
+                vec![
+                    "2020-09-08T00:00:00Z",

Review Comment:
   I think the test I had for the "-02" zone was sufficient. The way times are 
stored is always as a UTC offset, the zone information really just indicates 
how the offset needs to be interpretted. These strings are only used to derive 
th offset and therefore the specified zone is ignored when creating the array. 
However, more tests don't hurt so I've added the ones you suggested for clarity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org