anjakefala commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1349219104
##########
cpp/src/arrow/dataset/parquet_encryption_config.h:
##########
@@ -29,44 +29,50 @@ struct DecryptionConfiguration;
namespace arrow {
namespace dataset {
-/// \brief Core configuration class encapsulating parameters for high-level
encryption
-/// within Parquet framework.
-///
-/// ParquetEncryptionConfig serves as a bridge, passing encryption-related
-/// parameters to appropriate components within the Parquet library. It holds
references
-/// to objects defining encryption strategy, Key Management Service (KMS)
configuration,
-/// and specific encryption configurations for Parquet data.
-///
-/// \member crypto_factory Shared pointer to CryptoFactory object, responsible
for
-/// creating cryptographic components like encryptors and decryptors. \member
-/// kms_connection_config Shared pointer to KmsConnectionConfig object, holding
-/// configuration parameters for connecting to a Key Management Service (KMS).
-/// \member encryption_config Shared pointer to EncryptionConfiguration
object, defining
-/// specific encryption settings for Parquet data, like keys for different
columns.
struct ARROW_DS_EXPORT ParquetEncryptionConfig {
std::shared_ptr<parquet::encryption::CryptoFactory> crypto_factory;
std::shared_ptr<parquet::encryption::KmsConnectionConfig>
kms_connection_config;
std::shared_ptr<parquet::encryption::EncryptionConfiguration>
encryption_config;
+ /// \brief Core configuration class encapsulating parameters for high-level
encryption
Review Comment:
@jorisvandenbossche The examples I see here:
https://github.com/apache/arrow/blob/c3fe65a8bd700231d9d40aa9638304706e8f0d99/cpp/src/arrow/dataset/file_parquet.h#L275
throughout this file are to put the general descriptor of the struct above the
struct, and then the descrptions of the properties within the struct, above the
property.
I am going to follow that approach, let me know if you would like something
different!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
