p-a-a-a-trick commented on code in PR #38075:
URL: https://github.com/apache/arrow/pull/38075#discussion_r1350553508
##########
cpp/src/arrow/compute/kernels/vector_selection_filter_internal.cc:
##########
@@ -998,6 +998,11 @@ class FilterMetaFunction : public MetaFunction {
Result<Datum> ExecuteImpl(const std::vector<Datum>& args,
const FunctionOptions* options,
ExecContext* ctx) const override {
+ if ((args[1].kind() != Datum::ARRAY) &&
+ (args[1].kind() != Datum::CHUNKED_ARRAY)) {
+ return Status::NotImplemented("Filter should be array-like");
Review Comment:
Sounds good to me. I got this from
[L945](https://github.com/apache/arrow/blob/ae16bde4b36fe5a404c8ca22fab769db0d652543/cpp/src/arrow/compute/kernels/vector_selection_filter_internal.cc#L945).
Should change that one as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
