pitrou commented on code in PR #37709:
URL: https://github.com/apache/arrow/pull/37709#discussion_r1352787992
##########
cpp/src/arrow/acero/swiss_join_internal.h:
##########
@@ -161,7 +161,7 @@ class RowArrayMerge {
//
static Status PrepareForMerge(RowArray* target, const
std::vector<RowArray*>& sources,
std::vector<int64_t>* first_target_row_id,
- MemoryPool* pool);
+ MemoryPool* pool, bool check_key_size);
Review Comment:
Nits:
1. let's keep the `MemoryPool*` argument at the end
2. perhaps change the argument name to not expose an implementation detail?
So for example:
```c++
static Status PrepareForMerge(RowArray* target, const
std::vector<RowArray*>& sources,
bool is_key_data, std::vector<int64_t>*
first_target_row_id,
MemoryPool* pool);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
