kou commented on code in PR #38195:
URL: https://github.com/apache/arrow/pull/38195#discussion_r1356087524
##########
dev/tasks/r/github.packages.yml:
##########
@@ -375,29 +375,30 @@ jobs:
read_parquet(system.file("v0.7.1.parquet", package = "arrow"))
print(arrow_info())
- #TODO test macos source build?
- test-linux-source:
+ test-source:
needs: source
- name: Test linux source build
- runs-on: ubuntu-latest
+ name: Test {{ '${{ matrix.platform.name }}' }} source build
Review Comment:
What is the difference with this "Test macOS source build" and "r-packages"?
It seems that both of them use pre-built Apache Arrow C++ and build Apache
Arrow R from source.
##########
dev/tasks/r/github.packages.yml:
##########
@@ -375,29 +375,30 @@ jobs:
read_parquet(system.file("v0.7.1.parquet", package = "arrow"))
print(arrow_info())
- #TODO test macos source build?
- test-linux-source:
+ test-source:
needs: source
- name: Test linux source build
- runs-on: ubuntu-latest
+ name: Test {{ '${{ matrix.platform.name }}' }} source build
+ runs-on: {{ '${{ matrix.platform.runs_on }}' }}
+ strategy:
+ fail-fast: false
+ matrix:
+ platform:
+ - {runs_on: "ubuntu-latest", name: "Linux"}
+ - {runs_on: ["self-hosted", "macos-10.13"] , name: "macOS"}
steps:
- name: Install R
+ if: matrix.platform.name == 'Linux'
uses: r-lib/actions/setup-r@v2
- with:
- install-r: false
{{ macros.github_setup_local_r_repo(false, false)|indent }}
- {{ macros.github_checkout_arrow()|indent }}
+ {{ macros.github_checkout_arrow(action_v="3")|indent }}
- name: Install sccache
+ if: matrix.platform.name == 'Linux'
shell: bash
run: |
arrow/ci/scripts/install_sccache.sh unknown-linux-musl /usr/local/bin
- - name: Install R package system dependencies
- run: |
- sudo arrow/ci/scripts/r_install_system_dependencies.sh
- env:
- ARROW_GCS: "ON"
- ARROW_S3: "ON"
- ARROW_SOURCE_HOME: arrow
+ - name: Install R package system dependencies (Linux)
+ if: matrix.platform.name == 'Linux'
+ run: sudo apt-get install -y libcurl4-openssl-dev libssl-dev
Review Comment:
Why do we want to use `apt-get install` directly instead of using
`arrow/ci/scripts/r_install_system_dependencies.sh`?
##########
dev/tasks/r/github.packages.yml:
##########
@@ -375,29 +375,30 @@ jobs:
read_parquet(system.file("v0.7.1.parquet", package = "arrow"))
print(arrow_info())
- #TODO test macos source build?
- test-linux-source:
+ test-source:
needs: source
- name: Test linux source build
- runs-on: ubuntu-latest
+ name: Test {{ '${{ matrix.platform.name }}' }} source build
+ runs-on: {{ '${{ matrix.platform.runs_on }}' }}
+ strategy:
+ fail-fast: false
+ matrix:
+ platform:
+ - {runs_on: "ubuntu-latest", name: "Linux"}
+ - {runs_on: ["self-hosted", "macos-10.13"] , name: "macOS"}
steps:
- name: Install R
+ if: matrix.platform.name == 'Linux'
uses: r-lib/actions/setup-r@v2
- with:
- install-r: false
{{ macros.github_setup_local_r_repo(false, false)|indent }}
- {{ macros.github_checkout_arrow()|indent }}
+ {{ macros.github_checkout_arrow(action_v="3")|indent }}
Review Comment:
It seems that we don't need this for macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
