tustvold commented on code in PR #7798:
URL: https://github.com/apache/arrow-datafusion/pull/7798#discussion_r1356535464
##########
datafusion/physical-plan/src/sorts/cursor.rs:
##########
@@ -275,6 +324,26 @@ impl<T: FieldValues> Cursor for FieldCursor<T> {
self.offset += 1;
t
}
+
+ fn slice(&self, offset: usize, length: usize) -> Result<Self> {
+ let FieldCursor {
+ values,
+ offset: _,
+ null_threshold,
+ options,
+ } = self;
+
+ Ok(Self {
+ values: values.slice(offset, length)?,
+ offset: 0,
+ null_threshold: *null_threshold,
Review Comment:
Is this correct? I think this will shift the nulls out of alignment? Perhaps
we could get a test of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
