berkaysynnada commented on PR #7793: URL: https://github.com/apache/arrow-datafusion/pull/7793#issuecomment-1759345499
> @berkaysynnada > > In order to make reviews go faster (and selfishly make it easier for me to review) would it be possible to break this PR into smaller PRs? > > For example, this would be an obvious candidate: > > > This change isn't directly related to this PR, but NegativeExpr's are now supported in interval arithmetic. > > I bet we can get that PR reviewed and merged quite quickly Unfortunately I cannot separate the big part of PR, but I could extract 2 parts: 1) [Related things with interval arithmetic for NegativeExpr](https://github.com/apache/arrow-datafusion/pull/7804), 2) [Initial implementation of Sharpness feature](https://github.com/apache/arrow-datafusion/pull/7809). The left part is the insertion of Sharpness into Statistics and functions where Statistics are analyzed. The focus can be on the algorithmic changes where I update the functions to bring them a more detailed and comprehensive approach. There are lots of repeating test and import changes that you can take a quick look at without wasting much time. If you can think of something else that would make the review easier, I can try it. Thank you for your time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
