alamb commented on code in PR #7805:
URL: https://github.com/apache/arrow-datafusion/pull/7805#discussion_r1356688765
##########
datafusion/core/src/dataframe.rs:
##########
@@ -663,12 +663,7 @@ impl DataFrame {
) -> Result<DataFrame> {
let expr = on_exprs.into_iter().reduce(Expr::and);
let plan = LogicalPlanBuilder::from(self.plan)
- .join(
- right.plan,
- join_type,
- (Vec::<Column>::new(), Vec::<Column>::new()),
- expr,
- )?
+ .join_on(right.plan, join_type, expr)?
Review Comment:
I was also thinking there are some additional documentation improvements
that can be done (namely suggesting people use `join_on` instead of the various
other join functions. I can make a PR with such improvements as a follow on,
perhaps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
