alamb opened a new pull request, #7819: URL: https://github.com/apache/arrow-datafusion/pull/7819
## Which issue does this PR close? Related to https://github.com/apache/arrow-datafusion/pull/7612 and https://github.com/apache/arrow-datafusion/issues/7611 ## Rationale for this change Since DataFusion should automatically identify join predicates, I thought the logic to extract join predicates in substrait should be redundant. However, it turns out that there is some subtlety related to `null == null` predicates I do not appreciate so I got stuck ## What changes are included in this PR? Simplify substrait join handling ## Are these changes tested? Yes, by existing tests (that are currently failing) <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
